Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#88 ejb:ejb-ref view-type="both"

closed
Brian Topping
ejbdoclet (29)
5
2002-09-13
2002-08-26
Gerald Turner
No

Neither XDoclet 1.1.2 or the CVS version can parse
ejb:ejb-ref with view-type="both", only
view-type="remote" and view-type="local".

XDoclet 1.1.2 allowed "both" functionality/work-around
by reading a pair of ejb:ejb-ref class tags with the
same ejb-name, one with view-type="remote" and the
other with view-type"local".

The current XDoclet doesn't allow "both" functionality
at all because the XDtEjbRef:forAllEjbRefs content tag
purposely skips ejb:ejb-ref tags with duplicate
ejb-name parameters. One could argue that this is a bug.

I've written a small patch that adds two content tags
to XDtEjbRef: ifRemoteRef and ifLocalRef, also updated
resources/ejb-body.xdt to use these tags rather than
XDtClass:ifClassTagValueEquals which ends up looking
cleaner because there was a redundant set of <ejb-ref>
(the remote ref) elements.

Discussion

  • Gerald Turner
    Gerald Turner
    2002-08-26

    Patch that adds XDtEjbRef:ifRemoteRef,ifLocalRef content tags, updates ejb-body.xdt

     
  • Gerald Turner
    Gerald Turner
    2002-08-26

    Logged In: YES
    user_id=571620

    Updated that patch to include doc.tag tags to the
    ifRemoteRef and ifLocalRef methods

     
  • Gerald Turner
    Gerald Turner
    2002-08-26

    Patch that adds XDtEjbRef:ifRemoteRef,ifLocalRef content tags, updates ejb-body.xdt

     
  • Gerald Turner
    Gerald Turner
    2002-08-26

    • summary: ejb:ejb-ref view-type="both" --> ejb:ejb-ref view-type="both"
     
  • Gerald Turner
    Gerald Turner
    2002-08-28

    Logged In: YES
    user_id=571620

    Oops, the patch (both) contained an extra ejb-jar.xml
    element, here's a new one that's been compiled *and* tested!

     
  • Gerald Turner
    Gerald Turner
    2002-08-28

    Third version of patch that adds XDtEjbRef:ifRemoteRef,ifLocalRef content tags, updates ejb-body.xdt

     
  • Gerald Turner
    Gerald Turner
    2002-08-28

    • summary: ejb:ejb-ref view-type="both" --> ejb:ejb-ref view-type="both"
     
    • assigned_to: nobody --> topping
    • summary: ejb:ejb-ref view-type="both" --> ejb:ejb-ref view-type="both"
     
  • Gerald Turner
    Gerald Turner
    2002-09-13

    Logged In: YES
    user_id=571620

    This patch can be closed because Ara has implemented an
    alternative to view-type="both": a pair of @ejb:ejb-ref tags
    with view-type="local" on one and view-type="remote" on the
    other is allowed again, like 1.1.2.

    I still think "both" would be cool, but my patch no longer
    applies cleanly because the ejb-ref portion of ejb-body.xdt
    has been split into ejb-ref.xdt, however, the
    EjbRefTagsHandler.java hunk still applies cleanly so...

     
  • Gerald Turner
    Gerald Turner
    2002-09-13

    • summary: ejb:ejb-ref view-type="both" --> ejb:ejb-ref view-type="both"
    • status: open --> closed