Re: [Xcsoar-devel] Pull request: Makefile fix

[Max K. <ma...@du...>]

On 2011/06/10 06:32, Scott Penrose <sc...@dd...> wrote:
> Howdy
> 
> Could you please pull
> 
> 	git://git.xcsoar.org/xcsoar/scottp/xcsoar.git makefile_fix
> 	commit dfc43ddbdbe269b82585f2d035f1c206c4bed8fc = Allow for alternative dist output dir. Allows for a make clean

I do not understand this commit (despite of your explanation below).
When you do "clean", why don't you want to delete the Altair ZIP
package?  And why do you want to make the Altair ZIP special, why not
the same for any other type of file? (the EXE files, Android package,
*.o, *.d, ...)

> 	commit 468b3dc65597b7c10e84e855d353d591b2b75133 = Fix makefile to use safe version name as directory (no spaces)

Version numbers do not have spaces.  Explain why this commit is useful
or necessary.

> The "make dist" was using the git id with spaces, and making directories in output/ and ./. Changes spaces to _.
> I often need to do a "make clean" if I change things, checkout other peoples code. But that gets rid of the output/*.zip. 
> So I have added a variable ZIP_OUT, e.g. ZIP_OUT=~/xcsoar_dist to optionally change directory. Defaults to ./output/ (existing).

When you have further explanation, please add it to the commit
message.  That way, it's preserved for the next generation.