#161 ENTER in Server List should connect to server

open
nobody
None
5
2005-03-19
2005-03-19
No

It would be nice if, in order to connect to a server, I
could simply:
1. Select it with the arrows, or
2. Use Gtk+ new type-as-you-find feature
and then simply press Enter (instead of Alt-O) to connect.

Currently, Enter performs a rename, which is a much
less-frequent action, so it shouldn't be the "default
action" (as Enter implies) IMHO.

Discussion

  • Jor
    Jor
    2006-02-18

    Logged In: YES
    user_id=1057882

    I also always intuitively press the enter button when I want
    to connect. But since enter and space default to a
    rename/edit on editable gtk trees views like this, I'm not
    sure messing with the default actions is a good idea (HIG
    wise). It's rather simple so set default focus to the
    connect button, disadvantage of this is that the keyboard
    arrow control don't directly apply to the network selection
    list. I prefer this option, since 99% of the time I just
    need to connect to the default selected network. But maybe
    somebody with more knowledge about the gnome HIG and gtk
    tree views should look into this.
    Anyway, a quick simple implementation:

    diff -u -r1.60 servlistgui.c
    --- servlistgui.c 2 Jan 2006 12:09:35 -0000 1.60
    +++ servlistgui.c 18 Feb 2006 16:04:53 -0000
    @@ -1421,8 +1421,8 @@
    gtk_label_set_mnemonic_widget (GTK_LABEL (label6), entry4);
    gtk_label_set_mnemonic_widget (GTK_LABEL (label7), entry5);

    - gtk_widget_grab_focus (networks_tree);
    - gtk_widget_grab_default (button_close);
    + gtk_widget_grab_focus (button_connect);
    + gtk_widget_grab_default (button_connect);
    return servlist;
    }

     
  • Logged In: YES
    user_id=335423
    Originator: YES

    Sorry for the delay. I've sent the issue to GNOME Usability. Hope they could hint us somehow.