#531 Alt+numbers do not work with X Input Method

closed-fixed
nobody
None
5
2004-03-22
2004-02-14
Marius Gedminas
No

If open the popup menu on the input box and select
Input Method -> X Input Method, key bindings for Alt+1
... Alt+9 stop working (instead of switching between
tabs they enter digits in the input box).

The reason is that the gtk input module interprets
these keystrokes and xchat's key_handle_key_pressAFTER
never sees them.

I propose to fix it by getting rid of
key_handle_key_pressAFTER and doing all the processing
in key_handle_key_press.

See http://bugs.debian.org/188862 for more information.

Discussion

  • Peter Zelezny.
    Peter Zelezny.
    2004-03-01

    Logged In: YES
    user_id=5012

    I don't know if this is so clear cut. That routine was moved
    to "after" event because it caused problems with other
    Input-Methods. I'll have to try to dig out the old bug
    report....

    Found it:
    https://sourceforge.net/tracker/?group_id=239&atid=100239&func=detail&aid=653751

    Does your patch re-open this bug? If not, I'll commit it to CVS.

     
  • Logged In: YES
    user_id=44660

    I did an experiment with pristine xchat2 and my patched
    version: I switched to Amharic and typed "selam<enter>". I
    got identical results in both cases: "&#4656;&#4619;&#4637;" got entered in
    the text box (Unicode characters <U1230><U120b><U120d>, in
    case SourceForge web interface mangles them). That's only to
    be expected, because even before my change xchat2 handled
    the Enter key in key_handle_key_press instead of in
    key_handle_key_pressAFTER.

    I cannot guarantee that my proposed change will work
    flawlessly with all input methods. If a hyphotetical input
    method wants to use Alt+numbers for entering, say, Unicode
    characters, with my change xchat2 will "steal" those keys
    from the input method. However in that case the user can
    simply remove the offending xchat2 shortcuts, while
    currently if a gtk input method "steals" keys from xchat2
    there is no workaround.

     
  • Peter Zelezny.
    Peter Zelezny.
    2004-03-15

    Logged In: YES
    user_id=5012

    Do you have a diff file please? I don't like applying this
    manually.

     
  • Logged In: YES
    user_id=44660

    Here's a diff. I just tested it with the latest CVS snapshot.

     
  • Peter Zelezny.
    Peter Zelezny.
    2004-03-22

    • status: open --> closed-fixed