#1524 Load python plugins from LIBDIR/plugins

open
nobody
None
5
2011-09-21
2011-09-21
Anonymous
No

Actually, this is currently working but for some strange reason, it's limit to WIN32 only.

Please apply the suggested patch below, it has been already uploaded on Debian pkgs:

--- xchat-2.8.8.orig/plugins/python/python.c
+++ xchat-2.8.8/plugins/python/python.c
@@ -62,6 +62,7 @@
#include "Python.h"
#include "structmember.h"
#include "pythread.h"
+#include "config.h"

#define VERSION_MAJOR 0
#define VERSION_MINOR 1
@@ -383,10 +384,7 @@ Util_Autoload()

/* auto-load from ~/.xchat2/ or %APPDATA%\X-Chat 2\ */
Util_Autoload_from(xchat_get_info(ph, "xchatdirfs"));
-
-#ifdef WIN32 /* also auto-load C:\Program Files\XChat\Plugins\*.py */
Util_Autoload_from(XCHATLIBDIR"/plugins");
-#endif
}

Discussion

  • Lian Wan Situ
    Lian Wan Situ
    2011-11-30

    That should be using xchat_get_info( ph, "libdirfs" ) instead of trying to include config.h and using XCHATLIBDIR

    The reason xchat doesn't already load from there is because it makes it impossible to disable anything installed in there in a multi user situation. The ideal fix would be auto loading from there AND having some sort of plugin manager.