vorbis Log


Commit Date  
[c5670a] by xiphmont xiphmont

More fixes to handle the null-entry codebook case. It appears the
failure to handle this case affects more of the code than thought;
many of the old low-bitrate crash cases trace back to this problem.

This also affects tremor. These changes are not yet thoroughly
tested.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13172 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 05:29:52 Tree
[d8d826] by xiphmont xiphmont

Apply patch as supplied in ticket 851

git-svn-id: http://svn.xiph.org/trunk/vorbis@13171 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 03:51:56 Tree
[836da0] by xiphmont xiphmont

The automated book training scripts managed to create a few residue
books with no codewords (in that mode with that partitioning scheme,
no values happened to fall into that partition). This is not really
an error.

However, the residue encoding code did not account for the possibility
of looking up a codebook best match and finding no entries. Because
the unused book only came up very rarely (four hours of training audio
didn't hit it once), it took a while to notice and only comes up on
platforms with subtly different FP than the machine used to do
training.

This bug affects very low bitrate stereo 8, 11, 16 and 22kHz modes;
added code to check for 'no match in codebook' (correct behavior is to
encode nothing) and for good measure, removed the four dummy codebooks
as there's no point in wasting a few bytes in the header to pack a
nothing.

Closes bug 1142.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13170 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 03:34:25 Tree
[25b184] by xiphmont xiphmont

Add additional check when attempting to encode values through
codebooks with no entries. Ideally that wouldn't happen, but it looks
like the automated codebook training ended up with a few 'null' books.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13169 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 03:01:47 Tree
[715e7c] by xiphmont xiphmont

Attempted fix for bug #300; the last comment identified a legitimate static bounds overrun that would have explained the behavior.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13168 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 01:02:19 Tree
[f8f7c5] by xiphmont xiphmont

Don't forget to test all changes in a code cleanup-- residue type 2 encoding was broken by last night's round of fixes.

Tested fixed.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13167 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-22 00:58:15 Tree
[5f0b14] by lu_zero lu_zero

Draft update

git-svn-id: http://svn.xiph.org/trunk/vorbis@13163 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 14:57:34 Tree
[875f58] by xiphmont xiphmont

Numerous small changes to resolve possible and certain issues found by
Coverity.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13162 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 07:06:25 Tree
[9a631b] by xiphmont xiphmont

Correct a cleanup dispatch error when a bitstream is rejected due to
illegal map/floor/residue type. The cleanup subdispatch was done by
type, unfortunately, the invalid type just read in. Fixed.

also bump lib revision.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13160 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 06:20:08 Tree
[ed73ba] by xiphmont xiphmont

Spec addition to clarify corner case; residue and floor decoded sections
may overflow the base vector's actual storage; this *must* be handled by
decoders.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13159 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 05:22:35 Tree
[8917ed] by xiphmont xiphmont

Catch one more omission in the vector length guarding

git-svn-id: http://svn.xiph.org/trunk/vorbis@13155 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 04:35:10 Tree
[604a1e] by xiphmont xiphmont

I had forgotten that the res2 top level interprets limits differently
than res0 and res1; guarding code (and garbled playback) fixed

git-svn-id: http://svn.xiph.org/trunk/vorbis@13154 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 04:22:33 Tree
[569985] by xiphmont xiphmont

If you're going to guard against max blocksize, make sure you choose the right blocksize.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13153 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 00:51:15 Tree
[6122c8] by xiphmont xiphmont

Additional bounds checking to guard against the case where a residue
or floor is decoding into a vector larger than the current blocksize.
This is not illegal, but no encoder has ever tried it and as such, it
had not been noticed that the code did not handle the case correctly.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13151 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-21 00:42:23 Tree
[00948a] by giles giles

Update change log with the news so far.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13150 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-20 22:25:42 Tree
[f2e8d8] by xiphmont xiphmont

Correct a bug where the guard code is allowing illegally small blocksizes.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13149 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-20 22:06:55 Tree
[5f2ca1] by lu_zero lu_zero

Fix the SDP example

git-svn-id: http://svn.xiph.org/trunk/vorbis@13132 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-13 00:32:41 Tree
[9ab230] by giles giles

Update autogen.sh to handle automake 1.10.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13069 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-07 22:19:17 Tree
[9ce171] by giles giles

Update the makefile to reference the updated rtp drafts.

git-svn-id: http://svn.xiph.org/trunk/vorbis@13068 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-06-07 21:07:21 Tree
[113b20] by lu_zero lu_zero

Draft updated

git-svn-id: http://svn.xiph.org/trunk/vorbis@12996 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-29 08:33:44 Tree
[a358ae] by lu_zero lu_zero

Latest batch of fixes

git-svn-id: http://svn.xiph.org/trunk/vorbis@12995 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-29 08:24:22 Tree
[0cb2d7] by lu_zero lu_zero

Make nut v understandable

git-svn-id: http://svn.xiph.org/trunk/vorbis@12946 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-14 13:00:02 Tree
[50e270] by lu_zero lu_zero

Fixed the Packed Headers Detail Figure

git-svn-id: http://svn.xiph.org/trunk/vorbis@12940 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-11 11:14:32 Tree
[59e128] by lu_zero lu_zero

First rephrase of the new header packing procedure, more pending

git-svn-id: http://svn.xiph.org/trunk/vorbis@12939 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-11 09:50:23 Tree
[71e922] by giles giles

Update the makefile for the new RTP draft revision number.

git-svn-id: http://svn.xiph.org/trunk/vorbis@12934 0101bb08-14d6-0310-b084-bc0e0c8e3800

2007-05-09 17:48:57 Tree
Older >