> "cache_file = "%s%s" % (path,'icecast.cache')" should be "cache_file =
> os.path.join(path,'icecast.cache')" as I am not sure how that would
> translate cross platform.
Fine. Being mostly a C programmer the try-catch stanza is not really
>>> try: os.mkdir(path)
>>> except: OSError
> is better as
>> if not os.path.exists(path):
my favourite, it's just that I saw it this way in a bunch of Python
> you can also "speed it up" by specifying cache_file only once below
> the BASE_URL as there is no need to do it twice in two different defs.
Not at all - I am thankful for all your corrections. You're actually
> sorry, I am not picking on you or the code, I am just making sure we
> minimize any potential errors.
helping me get a taste of Python programming (I've never touched it so
far, preferring old-school C and Perl) and also learn a little more on
XBMC internals (I've been using it since Atlantis, but mostly as an
I'll fix the code and send next [SVN Pull] probably tomorrow morning
(i.e. in some 12 hours, it's now evening my time).