Re: [Wonder-disc] I started getting unbalanced WebObjects tag errors

[Hugi Þ. <hu...@ka...>]

Whoops, my bad - sorry about that. It's from a patch I submitted a little while ago, I had no idea people use attributes in closing tags.

I guess I unconsciously pooped in the pool before I left :-).

- hugi


On Sep 15, 2010, at 4:41 PM, Ricardo J. Parada wrote:

> 
> 
> 
> I think I know what it is.  It's in WOHelperFunctionHTMLParser.java:101:
> 
> 101:				else if (tagLowerCase.startsWith(WEBOBJECT_END_TAG) || tagLowerCase.startsWith(WO_COLON_END_TAG) || tagLowerCase.equals(WO_END_TAG)) {
> 						endOfWebObjectTag(token);
> 					}
> 
> The last part of that should be startsWith() instead of equals().
> 
> I'll submit a patch.
> 
> 
> 
> On Sep 15, 2010, at 3:23 PM, Kieran Kelleher wrote:
> 
>> FWIW, I just looked at my svn commit history and I hit this problem when I updated from Wonder svn rev 10953 to rev 11124, so it was somewhere between those two.
>> 
>> .... and yes, it is useful for big nested container tags without a doubt.
>> 
>> 
>> On Sep 15, 2010, at 2:14 PM, Chuck Hill wrote:
>> 
>>> Has anyone filed a Jira on this? Was it just Wonder that you updated?  Isn't this a WOLips issue?
>>> 
>>> 
>>> 
>>> On Sep 15, 2010, at 11:05 AM, Ricardo J. Parada wrote:
>>> 
>>>> 
>>>> 
>>>> It comes in different flavors though.  For example, any of the following closing tags cause the error:
>>>> 
>>>> </wo name="Foo">
>>>> 
>>>> 	or 
>>>> 
>>>> </wo:ERXWOTemplate templateName="Foo">
>>>> 
>>>> 	or
>>>> 
>>>> </webobject name="Foo">
>>>> 
>>>> 
>>>> I'm searching my *.html files in all of our projects to see how bad it is for us to comply.  But like Chuck said, I find it easier to read and maintain in the component editor. 
>>>> 
>>>> :-)
>>>> 
>>>> 
>>>> 
>>>> On Sep 15, 2010, at 1:35 PM, Kieran Kelleher wrote:
>>>> 
>>>>> I got this in a recent Wonder update a few weeks ago too. I had only used it in a few old components, so I just changed it to the usual way closing with only </wo>.  I had not seen any other people complaining so I thought I was the only one using this feature and did not feel it was worth it to be bothering MS with it.
>>>>> 
>>>>> Regards, Kieran
>>>>> 
>>>>> 
>>>>> On Sep 15, 2010, at 1:03 PM, Ricardo J. Parada wrote:
>>>>> 
>>>>>> Hi All,
>>>>>> 
>>>>>> I started getting the unbalanced WebObjects tag errors whenever I have stuff like this:
>>>>>> 
>>>>>> 	<wo name="Foo">
>>>>>> 		Test
>>>>>> 	</wo name="Foo">
>>>>>> 
>>>>>> NOTICE the closing tag.  We have a lot of closing tags like this.  I'm gonna try to check out a previous version to see if it the error goes away.
>>>>>> 
>>>>>> I know it may not be correct syntax but I kinda liked it because it makes it easier to track what tag I'm closing.  Specially when there's a lot of stuff in between the opening and closing tags.
>>>>>> 
>>>>>> Does anybody else get this error with recent Wonder versions?  Or am I missing a property?  :-)
>>>>>> 
>>>>>> Thanks
>>>>>> Ricardo
>>> 
>>> -- 
>>> Chuck Hill             Senior Consultant / VP Development
>>> 
>>> Practical WebObjects - for developers who want to increase their overall knowledge of WebObjects or who are trying to solve specific problems.    
>>> http://www.global-village.net/products/practical_webobjects
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
> 
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev_______________________________________________
> Wonder-disc mailing list
> Won...@li...
> https://lists.sourceforge.net/lists/listinfo/wonder-disc


------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev_______________________________________________
Wonder-disc mailing list
Won...@li...
https://lists.sourceforge.net/lists/listinfo/wonder-disc