#32 Remove bitmap resources from lang files

closed-fixed
Tim Gerundt
2
2007-03-27
2006-03-11
Kimmo Varis
No

Currently every lang file contains copy of all bitmaps
(except splash screen after my latest patch). I don't
see a real reason for this.

There is no reason to localize icons or toolbar. So we
could use just one copy of all bitmaps in Merge.rc.

This reduces size of lang files and also makes changes
easier since there is no need to add/change bitmap
references in every lang's .rc file.

Discussion

  • Kimmo Varis
    Kimmo Varis
    2006-03-11

    • priority: 5 --> 2
     
  • elsapo
    elsapo
    2006-03-11

    Logged In: YES
    user_id=1195173

    Maybe at some point I'll look into whether I could fix the
    English rc file to something like so

    #if LANG=ENG
    #include bitmaps
    #endif

    because then that could be in all RC files, and the
    difference this patch introduces would then be removed.

     
  • Kimmo Varis
    Kimmo Varis
    2006-06-12

    Logged In: YES
    user_id=631874

    Moving to todo-list.

     
  • Kimmo Varis
    Kimmo Varis
    2006-06-12

    • labels: 572061 --> Resources and Language DLLs
    • milestone: 438013 -->
     
  • Kimmo Varis
    Kimmo Varis
    2007-03-27

    Logged In: YES
    user_id=631874
    Originator: YES

    I'll assign this to Tim and close this as fixed now.

    In 2.7.3.2 bitmaps are now only in executable (which among other things reduced size to around 100 KB).

     
  • Kimmo Varis
    Kimmo Varis
    2007-03-27

    • assigned_to: nobody --> gerundt
    • status: open --> open-fixed
     
  • Kimmo Varis
    Kimmo Varis
    2007-03-27

    • status: open-fixed --> closed-fixed