Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2993 Drop UNICODE preprocessor definition

Branch_+_Trunk
closed-fixed
nobody
3
2010-11-21
2010-11-06
Tim Gerundt
No

This patch drops the UNICODE preprocessor definition from source files.

Greetings,
Tim

Discussion

  • Kimmo Varis
    Kimmo Varis
    2010-11-20

    Src/Common/wclassdefines.h looks to be file copied from somewhere else and should be left intact. So it is easier to update the file if needed.

    Are you sure you want to remove UNICODE from project files (Src/Merge.vcproj and Src/MergeX64.vcproj)?

    Src/StdAfx.cpp: places calling IsUnicodeBuild() should be fixed also since the function now always returns TRUE. But that can be done in new patch.

    Same for Src/stringdiffs.cpp's IsLeadByte().

    So other than Src/Common/wclassdefines and project files parts the patch looks good.

     
  • Tim Gerundt
    Tim Gerundt
    2010-11-20

    Committed with your objections to SVN (In Revision 7433)...

    Should I backport it also to branch R2_14?

     
  • Tim Gerundt
    Tim Gerundt
    2010-11-20

    • status: open --> open-accepted
     
  • Kimmo Varis
    Kimmo Varis
    2010-11-20

    >Should I backport it also to branch R2_14?
    Go ahead.

     
  • Tim Gerundt
    Tim Gerundt
    2010-11-21

    • milestone: 438013 --> Branch_+_Trunk
    • status: open-accepted --> closed-fixed
     
  • Tim Gerundt
    Tim Gerundt
    2010-11-21

    Committed to SVN branch R2_14 (In Revision 7436)...