#2707 Add compare statuses without bin/text info

Trunk
closed-accepted
Kimmo Varis
Usability (141)
5
2008-11-04
2008-10-18
Kimmo Varis
No

But (one of them) #2161575 Different binary files use "text file" icon
http://winmerge.org/bug/2161575

Forum post:
http://apps.sourceforge.net/phpbb/winmerge/viewtopic.php?f=6&t=4
Generalized identical/different compare status?

This patch adds two new folder compare statuses:
- files are identical
- files are different
which don't specify if the file is text file or binary file. Because we don't know that.

The code is altered so that in date/size compare we use these new statuses as there is no way to determine text/binary status. Also in quick compare if status is determined without reading files fully we use these new statuses. As we can determine files different from first few bytes and any text/bin status would be just lucky guess.

There are two new status icons. I quickly modified them from current icons.

Discussion

  • Kimmo Varis
    Kimmo Varis
    2008-10-18

    Original and altered files.

     
    Attachments
  • Kimmo Varis
    Kimmo Varis
    2008-10-20

    Updated patch - adds missing modified icon

     
    Attachments
  • Kimmo Varis
    Kimmo Varis
    2008-10-20

    I forgot one modified icon file from the first zip. That modified icon now becomes the "general" identical file -icon (not known if it is text or binary file).

    File Added: TextFileStatus2.zip

     
  • Kimmo Varis
    Kimmo Varis
    2008-10-20

    Committed to SVN trunk:
    Completed: At revision: 6021

     
  • Kimmo Varis
    Kimmo Varis
    2008-10-20

    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis
    Kimmo Varis
    2008-11-04

    • status: open --> closed-accepted
     
  • Kimmo Varis
    Kimmo Varis
    2008-11-04

    Closing this item.