#15 WinMerge crashes/fails in WinCVS

closed-accepted
nobody
None
5
2003-02-18
2002-10-29
Anonymous
No

WinDiff fails (the release version), crashes (the CVS
build) when using it to do a diff on file.

The bug has appeared in the new beta versions of
WinCVS. It is actually a bug in WinCVS which keeps the
file locked when checking out a temoprary copy and
invoking WinMerge.

However WinMereg can't open the locked file for readin
(WinMerge bug), and additionally the CVS version of
code does not clean up either, causing a crash.

The problem is in CCrystalTextBuffer::LoadFromFile
function.
The options for CreateFile shold be changed. I changed
the options to following to get it to work.
FILE_SHARE_READ + FILE_SHARE_WRITE

Previously it was just FILE_SHARE_READ.

Additionally the __finally block does not clean up a
invalid file handle, causing a crash in subsequent file
operaions.

Hope this helps. If you need more info, email me at
zafar@kaygees.com

Discussion

  • Christian List
    Christian List
    2002-12-06

    Logged In: YES
    user_id=609728

    I am not able to reproduce this problem.
    What versions are you using ?

    I am using the WinMerge beta from 11-2002 and WinCVS
    1.3.8.1 on a Windows 2000 machine.

     
  • Christian List
    Christian List
    2003-02-12

    • status: open --> open-accepted
     
  • Christian List
    Christian List
    2003-02-12

    Logged In: YES
    user_id=609728

    I tested this, and it seems to work either way, so I have
    committed the change to CVS.

     
  • Christian List
    Christian List
    2003-02-18

    • status: open-accepted --> closed-accepted