#836 Exit Warning?

closed-fixed
Kimmo Varis
Usability (267)
6
2007-07-25
2007-02-14
Alan
No

I have used WinMerge for years programming in several languages for several employers, it has become an invaluable part of my toolkit.
BUT . . .
With my current employer, we have several programmers maintaining the same (relatively small number of) projects written for the most part in VB6. Visual Sourcesafe is used for control, and I have implemented a 'safe' procedure for merging differences between my working version and the sourcesafe version. The projects, whilst few are massive. and a recursive folder compare of the project takes some time. I'm not worried about that, it's expected on a large folder tree. However what I find so irritating is, having spent some time checking file differences to see which way, or whether to merge, I click on the icon to close window. This is so close to the 'close application' icon on the form titlebar that a slight misplacement of the mouse means that the application closes (without warning), meaning that the scan has to be redone!
PLEASE provide at least the option to be warned when exiting the application, so that fumble fingered users can say WHOOPS!

Whilst I'm at it, feature request 1647433 from zamescurran has my vote.
When comparing VB6 source, Winmerge has a habit of insisting that a file has several differences at a po1nt where the only difference is that a new function or sub has been added. This has the knock on effect of offsetting file positions, and causing erroneous differences to be reported in the remainder of the file. Ideally some means of telling the diff engine that comparison should restart at a stated point in each file would be brilliant. (obviously this should cater for multiple such points in the file(s). I don't see it being necessary to 'remember' these file offsets between comparisons, because further changes will have been made by then.

Thanks for reading this epic (if you did)
Regards ...Alan

Discussion

  • Kimmo Varis
    Kimmo Varis
    2007-02-17

    • labels: --> Usability
    • priority: 5 --> 6
     
  • Kimmo Varis
    Kimmo Varis
    2007-02-17

    Logged In: YES
    user_id=631874
    Originator: NO

    Thanks for a good and descriptive request.

    I've numerous times run into the same problem, closing WinMerge accidentally. For file compare it usually doesn't matter, files rarely are so large they take time to re-load. But for large folder compares it is a real problem.

    I don't want to add lots of unnecessary warning for users, as most cases the closing is the real thing and user wants really to close the application. So unnecessary warnings just annoy. A lot.

    But I think we can add optional warning for closing folder compare.

    Still, it would be nice to able to reduce warnings, maybe there would be some idea to warn only about compares user has done some actions, opened files to merge, copied files etc. So that if user just compares two folders, looks at results and wants to close compare doesn't get the warning? But the user who is working with results gets a warning.

     
  • Alan
    Alan
    2007-02-21

    Logged In: YES
    user_id=1719121
    Originator: YES

    Hi kimmov, Thanks for your prompt response.
    I'm not suggesting that the warning be there automatically, and for everyone, but that there should be an option for such a warning.
    The conditions under which I would need a warning are:
    Winmerge is in he process of a (recursive) folder compare.
    The File compare window is open.
    The 'close Application' button is clicked rather than the 'close window'.
    Maybe instead, if the file compare window is open under these conditions, then instead of exiting the application, the open window is closed.
    OK this might then mean an extra click if you really meant to close the application, but would save an awful lot of clicks (and time) if (like me) that wasn't what you really wanted.

    Regards .. Alan

     
  • Logged In: YES
    user_id=859226
    Originator: NO

    I also frequently mis-click the application close button when only intending to close a file compare window. I would suggest a warning dialog box whenever there is more than 1 window open. I really like the way Firefox handles my mis-clicks which aren't restricted to WinMerge.

    Firefox displays a "Confirm close" dialog with the text "You are about to close 2 tabs. Are you sure you want to continue?" and a "Warn me when I attempt to close multiple tabs" checkbox. From here I can press the "Close tabs" button or the "Cancel" button. Unchecking the checkbox in the dialog unchecks the "Warn me when closing multiple tabs" checkbox in the Options.

     
  • Kimmo Varis
    Kimmo Varis
    2007-07-20

    Logged In: YES
    user_id=631874
    Originator: NO

    Hmm. That sounds like a reasonable approach.

    I first thought we should only warn if there are one or more folder compare windows open. But then I realized this one question will save many clicks from user if there are many open file compares with many modified files. As every modified file compare would also ask from user if one wants to save..

    I'll submit a patch.

     
  • Kimmo Varis
    Kimmo Varis
    2007-07-20

    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis
    Kimmo Varis
    2007-07-20

    Logged In: YES
    user_id=631874
    Originator: NO

    I submitted new patch item for this:
    #1757800 Ask user when exiting with many compare windows open
    http://winmerge.org/patch/1757800

    As mentioned in the description, I didn't add an option to enable/disable it. I think I want to enable this for all users in one experimental release and hear the feedback. ;)

     
  • Kimmo Varis
    Kimmo Varis
    2007-07-25

    • status: open --> closed-fixed
     
  • Kimmo Varis
    Kimmo Varis
    2007-07-25

    Logged In: YES
    user_id=631874
    Originator: NO

    I've committed that patch to SVN. So this warning will be in next 2.7.x releases.

    Closing this item now.