#605 Allow using 'Quick contents' compare for big (binary) files

closed-fixed
Kimmo Varis
7
2005-07-08
2005-06-28
Kimmo Varis
No

We currently have problems comparing big binary files.
Current code creates two buffers for every file, so it
takes lot of memory for big files.

Fortunately there is solution: Compare by Quick
Contents doesn't create those buffers and allows
checking if big files are identical or different.

Currently comparing too big files produces error
result, using quick contents allows us at least show if
files are identical/different.

My suggestion is to automatically compare bigger than X
MB files using Compare by Quick Contents. I think X
should be something like 2-10 MB. It could be an
compare option but I don't really see need for option
for this.

It would be nice if we could use current compare for
text files and Compare by Quick Contents for all binary
files. Problem is we don't know before comparing if
file is text file or binary file. So checking if file
is text or binary propably takes more time than we
would save using faster compare method (current compare
time < check + Compare by Quick Contents?).

Discussion

  • Kimmo Varis
    Kimmo Varis
    2005-07-07

    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis
    Kimmo Varis
    2005-07-08

    • status: open --> closed-fixed
     
  • Kimmo Varis
    Kimmo Varis
    2005-07-08

    Logged In: YES
    user_id=631874

    Patch is applied to CVS trunk, so I'm closing this as fixed.