Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1115 Inconsistent compiler optimization for Diff.cpp

open
nobody
None
3
2006-03-08
2006-01-03
elsapo
No

cvs trunk, Unicode Release

...WinMerge\Src\Diff.cpp(28) : warning C4653: compiler
option 'Optimizations (one or more of /Oawp[y])'
inconsistent with precompiled header; current
command-line option ignored

Sure enough, looking at project settings in Visual
Studio 6, the Unicode Release Optimizations setting for
Diff.cpp (Maximize Speed) is different from the other
cpp files (Minimize Size).

I traced back the last 6 or 7 changes to Merge.dsp and
didn't see anything that could have done this.

Looking in the dsp, this is also apparent, as Diff.cpp
(and some other diffutils files) have ifdefs &
customized settings.

(I thought I found & fixed this once before, long ago,
but I'm not sure.)

Discussion

  • elsapo
    elsapo
    2006-01-03

    Logged In: YES
    user_id=1195173

    Looking back through cvs history for Merge.dsp, it looks to
    me like Diff.cpp has had locally customized optimizer
    setting since the very start, so this bug has always been
    present. Possibly it became apparent, but we didn't notice,
    with the 2004-09-20 change in Unicode Release settings.

    Anyway, I assume we don't really want special optimizer
    settings for Diff.cpp or any other source files?

     
  • Kimmo Varis
    Kimmo Varis
    2006-01-03

    Logged In: YES
    user_id=631874

    I don't see real need for special optimizer. Diffing isn't
    our slowest code..

     
  • Kimmo Varis
    Kimmo Varis
    2006-03-08

    • priority: 5 --> 3
     
  • Kimmo Varis
    Kimmo Varis
    2006-03-08

    Logged In: YES
    user_id=631874

    Lowering priority.