#14 [PATCH] mingw32 compile of libWildMidi fails bad C syntax

v0.2.3
closed-out-of-date
Chris Ison
5
2010-07-30
2010-07-25
Avuton Olrich
No

I hardly know C, but this does let the compilation continue. Thx.

diff --git a/src/wildmidi_lib.c b/src/wildmidi_lib.c
index 093c1e0..1db3119 100644
--- a/src/wildmidi_lib.c
+++ b/src/wildmidi_lib.c
@@ -501,7 +501,7 @@ WM_LoadConfig (const char *config_file)
}
} else if (strcasecmp(line_tokens[0],"source") == 0) {
# if (defined _WIN32) && !(defined __CYGWIN__)
- if (!((isalpha(line_tokens[1][0])) && (strncmp(&line_token[1][1]":\\",2) == 0)) && (config_dir != NULL)) {
+ if (!((isalpha(line_tokens[1][0])) && (strncmp("%s:\\",&line_tokens[1][1],2) == 0)) && (config_dir != NULL)) {
# else
if ((line_tokens[1][0] != '/') && (line_tokens[1][0] != '~') && (config_dir != NULL)) {
# endif

Discussion

  • Avuton Olrich
    Avuton Olrich
    2010-07-25

    • labels: --> Build Process
    • milestone: --> v0.2.3
     
  • Avuton Olrich
    Avuton Olrich
    2010-07-25

    • assigned_to: nobody --> wildcode
     
  • Chris Ison
    Chris Ison
    2010-07-25

    what are you using to compile the mingw32 version?

     
  • Avuton Olrich
    Avuton Olrich
    2010-07-25

    Handmade scripts that I created for keeping a win32/musicpd port up to date, though I haven't committed the changes to add wildmidi support yet; it will happen soon. http://git.musicpd.org/cgit/avuton/mpd-release-utils.git/

     
  • Chris Ison
    Chris Ison
    2010-07-25

    hmm k, the win32 builds I do under cygwin do not error there. they error if i dont build and install the library 1st. ... I will have win32 player and dll up in a couple of weeks after the tests are complete. Would be helpful if you could provide more detail about how you are building wildmidi, so I could attempt to duplicate the error.

     
  • Chris Ison
    Chris Ison
    2010-07-25

    oops, sorry just noticed that you wer using the 0.2.3 linux release source which doesnt have the win32 build fixes. The svn has the win32 fixes but wont be released yet as I am waiting to hear of any more bugs.

    You will need to build and install the library before the client for the mingw32 build under cygwin.

     
  • Chris Ison
    Chris Ison
    2010-07-25

    • status: open --> pending-out-of-date
     
  • Chris Ison
    Chris Ison
    2010-07-30

    win32 fixes are in the 0.2.3.4 release, and this release includes a zip of the appropriate files.

     
  • Chris Ison
    Chris Ison
    2010-07-30

    • status: pending-out-of-date --> closed-out-of-date