#68 patch for mod_webkit2.c to work with apr-1.0.0

closed-accepted
WebKit (45)
5
2005-10-28
2005-01-02
Radoslaw Kintzi
No

This patch fix problems with mod_webkit2 and apr-1.0.0.
Like I said on webware-devel:
"It seems like they don't like APR_BRIGADE_FOREACH
macro any more. And there is an extra argument in
apr_socket_create function to specify protocol of the
socket. It can have one of value: APR_PROTO_TCP,
APR_PROTO_UDP or APR_PROTO_SCTP."
I choose APR_PROTO_TCP in this patch.
And we should use apr_socket_send and
apr_socket_connect functions instead of apr_send and
apr_connect.

See:
*
http://apr.apache.org/docs/apr-util/group__APR__Util__Bucket__Brigades.html#a80
*
http://apr.apache.org/docs/apr/group__apr__network__io.html#ga6

Radek

Discussion

  •  
    Attachments
    • status: open --> closed
     
  • Logged In: YES
    user_id=193957

    Thanks for the patch. I have checked it in for Webware
    version 0.9.

    I have added a check for APR_MAJOR_VERSION for the extra
    argument in apr_socket_create; the rest should be downward
    compatible.

     
    • assigned_to: nobody --> cito
    • status: closed --> closed-accepted