#67 Patch to update lastAccessTime in Session

closed
nobody
WebKit (45)
5
2007-04-22
2004-10-06
Anonymous
No

This is a patch to update the lastAccessTime attribute
in WebKit.Session whenever the value dictionary is
accessed. I believe that this is the expected
behaviour. The code prior to this patch only updates
the lastAccessTime on a new Transaction or on awake().
awake() is not always called, so sessions sometimes go
prematurely stale.

Discussion

  •  
    Attachments
  • Better diff file against Webware 0.9.1

     
    Attachments
  • Logged In: YES
    user_id=193957

    I'm not sure whether this is a good idea because of its
    impact on performance if you call time() for every session
    value you access. Actually, awake() should be called
    whenever a servlet with a session is accessed. If awake() is
    not called, this rather indicates that something is going
    wrong. So I haven't checked this in, but I keep this patch
    open for review by others and since you diff'ed tabs against
    spaces, I attached a better diff file.

     
    • status: open --> closed
     
  • Logged In: YES
    user_id=193957
    Originator: NO

    Closing this now.