#49 Incorrect call to self.delValue() in Session.__delitem__()

closed
nobody
WebKit (58)
5
2003-08-14
2003-08-14
Michael Casaday
No

Session.__delitem__() improperly calls Session.delValue()
with self as the first explicit argument:

def __delitem__(self, name):
self.delValue(self, name)

This causes exceptions like this to be thrown:

File "WebKit\Session.py", line 145, in __delitem__
self.delValue(self, name)
TypeError: delValue() takes exactly 2 arguments (3
given)

The fix is obvious:

def __delitem__(self, name):
self.delValue(name)

Discussion

  • Geoff Talvola
    Geoff Talvola
    2003-08-14

    • status: open --> closed
     
  • Geoff Talvola
    Geoff Talvola
    2003-08-14

    Logged In: YES
    user_id=88162

    This had already been fixed in Webware CVS since 0.8 was
    released, but the 0.8.1 release didn't include the fix.

    I moved the branch tag on Session.py so that the next
    release, whether 0.8.2 or 0.9, will include the fix.