bacula-backup start/stop/restart patch

Webmin
hansaplast
2014-02-26
2014-02-26
  • hansaplast
    hansaplast
    2014-02-26

    Hi,

    The buttons [Start/Stop and Restart Bacula] in the Bacula Backup System do
    not function correctly. Only the bacula-dir daemon is stopped and returns
    and an error is returned.

    Failed to stop Bacula : Failed to start bacula-dir :
    
    Shutting down bacula-dir: [ OK ]
    

    I took a look at the code and found the problem.

    System: CentOS release 6.4
    Webmin: webmin-1.660-1

    File: bacula-backup-lib.pl
    Function: run_all_inits
    ln: 626
    Result: Error handling fails.

    Clicking [Stop Bacula] button executes init::stop_action (ln 626). The
    returned result is incorrectly handled. For now I've commented out the error
    handling but a 'real' developer should fix this.

    Best Regards, Hansa

    627,629c627,629
    <       if ($err) {
    <               return &text('start_erun', "<tt>$i</tt>",
    "<pre>$err</pre>");
    <               }
    ---
    >       #if ($err) {
    >       #       return &text('start_erun', "<tt>$i</tt>",
    "<pre>$err</pre>");
    >       #       }
    
     
    Last edit: hansaplast 2014-02-26