#4397 bacula-backup start/stop/restart patch

[hansaplast]

The buttons [Start/Stop and Restart Bacula] in the Bacula Backup System do not function correctly. Only the bacula-dir daemon is stopped and an error is returned.

Failed to stop Bacula : Failed to start bacula-dir :

Shutting down bacula-dir: [ OK ]

I took a look at the code and figured out that init::start_action, init::stop_action and init::restart_action results are incorrectly handled or the result is invalid.

System: CentOS release 6.4
Webmin: webmin-1.660-1
Module: Bacula Backup System
Module Config: Use "Init scripts" instead of default "bacula command"

File: /usr/libexec/webmin/bacula-backup/bacula-backup-lib.pl
Function: run_all_inits
ln: 626
Result: Error handling fails.

Clicking [Stop Bacula] button executes init::stop_action (ln 626). The returned result is incorrectly handled. For now I've commented out the error handling but a 'real' developer should fix this.

Best Regards, Hansa

627,629c627,629
<       if ($err) {
<               return &text('start_erun', "<tt>$i</tt>",
"<pre>$err</pre>");
<               }
---
>       #if ($err) {
>       #       return &text('start_erun', "<tt>$i</tt>",
"<pre>$err</pre>");
>       #       }

[Jamie Cameron]

A fix for this will be in the next Webmin release. You can actually see the code already at https://github.com/webmin/webmin/commit/99d99719fc97f7bb7eead920437e048af5594579

[hansaplast]

hansaplast wrote:
... a 'real' developer should fix this

And he did ;-)
Thanks (again) Jamie!