#2396 doubleing the user

1.250
closed
Jamie Cameron
5
2006-02-24
2006-01-18
Justin L. Boss
No

it is doubleing the user name when you edit a user.
so say if you have a user "tom" and you edit his
passwd or anything else then now the user name is now
"tom tom" as well as the home directory. if you
create a user with this mod then edit the user you
just created will now be tripled "tom tom tom".

Discussion

  • Jamie Cameron
    Jamie Cameron
    2006-02-14

    Logged In: YES
    user_id=129364

    That is extremely odd, and it doesn't happen on my system.
    Which Webmin theme are you using?
    Does it go away if you upgrade to 1.260?

     
  • Eloi Granado
    Eloi Granado
    2006-02-21

    Logged In: YES
    user_id=740589

    Confirmed with Webmin 1.180 on a Debian Linux Sarge
    system. The character between the copies of the username
    isn't a space, but a null. The module that causes it to
    triple the username instead of "only" doubling it is the
    "mailboxes" one.

     
  • Eloi Granado
    Eloi Granado
    2006-02-21

    Logged In: YES
    user_id=740589

    By the way, the user must have access to the module, it
    isn't sufficient that it is installed.

    Just for your information : that happens even with the
    "modify user in other modules" option deactivated, and the
    "command to run before/after making changes" options
    emptied.

    I may submit a strace output of webmin execution while
    modifying an user if needed.

     
  • Jamie Cameron
    Jamie Cameron
    2006-02-21

    Logged In: YES
    user_id=129364

    Thanks for the information..
    I could add a work-around for this, but would be interested
    to find the real underlying cause. I suspect that it may be
    triggered by certain browsers - what browser are you using
    there?

     
  • Eloi Granado
    Eloi Granado
    2006-02-23

    Logged In: YES
    user_id=740589

    I've tested with Konqueror 3.5 and Firefox 1.5 and the
    problem only arises in Konqueror. Here you have the POST
    data sent to save_user.cgi resulting from clicking the
    "Save" button in the edit_user.cgi form :

    From Firefox :
    num=21&user=myadmin&uid=1000&real=administrator&home_base=1&home=&shell=%2Fbin%2Fbash&pass=&passmode=2&encpass=blablabla&othersh=&expired=&expirem=1&expirey=&min=0&max=99999&warn=7&inactive=&gid=users&movehome=1&chuid=1&chgid=1&others=1

    From Konqueror :
    num=21&user=myadmin&uid=1000&real=administrator&home_base=1&home=&shell=%2Fbin%2Fbash&pass=&passmode=2&encpass=blablabla&othersh=&expired=&expirem=1&expirey=&min=0&max=99999&warn=7&inactive=&gid=users&movehome=1&chuid=1&chgid=1&others=1&username=myadmin&user=myadmin&num=21&user=myadmin

    So, where do the additional final fields in Konqueror come
    from? They come from the *other* subsequent forms (show
    logins, read email, delete). And the triplication of the
    username comes from the concatenation of the the three
    "user" fields. Konqueror is sending the fields of the four
    forms from the submit button of the first one.

    What I don't know is whether the error comes from
    Konqueror or Webmin. I don't see any fatal error in the
    html code, so it may come from Konqueror. But, also, the
    doctype is html 3.2, and the W3 Validator sure complains a
    lot, so I don't really know which one is misbehaving.

    But I've found this theorically solved konqueror bug from
    1999, that really looks like it could be the cause of the
    problem we are discussing here :
    http://bugs.kde.org/show_bug.cgi?id=2126

    If no error is found in the HTML code that Webmin
    generates for that form, I may try to get that Konqueror
    bug report reopened.

     
  • Jamie Cameron
    Jamie Cameron
    2006-02-24

    Logged In: YES
    user_id=129364

    I think this is really a Konqueror bug then, assuming that
    you are using the latest Webmin version (1.260), which I
    have confirmed uses proper HTML.
    The page has two forms like :

    <form action=foo>
    <input name=user>
    </form>

    <form action=bar>
    <input type=hidden name=user>
    </form>

    Yet somehow the second user input is being included in
    the first form!

    Regardless, I will add a work-around for this Konqueror bug
    to the next Webmin release.

     
  • Jamie Cameron
    Jamie Cameron
    2006-02-24

    • status: open --> closed