#1153 Can't login to webmin after upgrading to 1.090. (FIXED)

1.090
closed
Jamie Cameron
5
2003-05-29
2003-05-28
Anonymous
No

My email address is tom@tom.cc.wayne.edu, and I have a
fix for the
1.090 login problem. See below.

After upgrading webmin from 1.080 to 1.090, I was
unable to login to
webmin.

I was running webmin 1.080 on several servers, so I
placed some code
in "lib/webmin-1.090/miniserv.pl" under both 1.080 and
1.090 that
would display my user id and password on the webpage.
Under both
1.080 and 1.090 the user id was displayed correctly,
but under 1.090
an extra CR was appended to the end of my password.
Under 1.080, no
extra CR was added to the password. In all cases I was
using the same
web browser for testing (Netscape version 6 for Solaris).

I noticed the following line of code in
"lib/webmin-1.090/miniserv.pl":

#$posted_data =~ s/\r|\n//g; # some browsers do this?

Although I was using the same browsers for all my
testing, I removed
the "#", and retried logging in. This time the login
worked without
problems.

What this tells me is that something has changed
between 1.080 and
1.090 that has stopped striping the CR from the
password at login, and
thus requires that:

$posted_data =~ s/\r|\n//g; # some browsers do this?

be included when it wasn't needed before. Please make:

$posted_data =~ s/\r|\n//g; # some browsers do this?

part of the standard distribution of webmin!

Discussion

  • Updated lib/webmin-1.090/miniserv.pl file to fix login problem under 1.090.

     
    Attachments
  • Jamie Cameron
    Jamie Cameron
    2003-05-29

    • status: open --> closed
     
  • Jamie Cameron
    Jamie Cameron
    2003-05-29

    Logged In: YES
    user_id=129364

    Ok, I will put this line back again in the next release ..
    thanks!

     
  • George D
    George D
    2003-05-29

    Logged In: YES
    user_id=789773

    Hi,
    how do I apply this update to my Toshiba SG20 server ?
    I can't login as well :(
    I know nothing about Linux :)
    Thanks George

     
  • Jamie Cameron
    Jamie Cameron
    2003-05-29

    Logged In: YES
    user_id=129364

    Webmin 1.094 will be available at
    http://www.webmin.com/devel.html tonight, and will include
    this fix.

     
  • Logged In: NO

    I just upgraded usermin to version 1.020, and it has the
    same problem, and the same fix.

    tom@tom.cc.wayne.edu

     
  • Jamie Cameron
    Jamie Cameron
    2003-06-17

    Logged In: YES
    user_id=129364

    Usermin 1.020 uses the same codebase as Webmin 1.090, so
    this is to be expected. It will also be fixed in the next
    release ..