#54 Support id attr on span etc.

closed-accepted
nobody
None
5
2010-08-12
2010-04-14
No

For the past month or so, the HTML on wikipedia has become such that w3m can't
use the Table of Contents (even with ID_EXT defined in config.h): the fragment
is identifed with an id attribute on a <span>, and w3m 0.5.2 "doesn't see" the
id in that case.

The attached patch addresses this, and navigation within wikipedia articles now
works again.

I wasn't very careful about what elements should or shouldn't honour id.
For example, I allowed it on <br>, and I allowed it on <listing> even though I
don't know what <listing> is (it isn't in
http://www.w3.org/TR/html4/index/elements.html\); whereas I didn't add it to a
few non-displayed things like <head>, <title>, <script>, <style>, nor some
table-related elements such as <col> and <thead>.

Unrelatedly, the patch adds a fixme comment where something looks unusual and
possibly accidental, though I haven't looked into it. Addressing the comment
is trivial for anyone with knowledge of TFLG_END: either s/0/TFLG_END/ in the
two places indicated, or change the fixme comment to a comment confirming that
it's deliberate.

This issue makes a big difference to the usability of w3m for wikipedia,
so I hope that either this patch is applied or the issue is addressed in some
other way.

pjrm.

Discussion

  • Patch to honour id on

     
    Attachments
  • Hiroyuki Ito
    Hiroyuki Ito
    2010-08-12

    • status: open --> closed-accepted