From: Brad K. <bra...@ki...> - 2013-12-05 14:12:16
|
Ozge, The vxl nightly dashboard builds have failed since you added this test: http://open.cdash.org/viewBuildError.php?buildid=3126535 .../core/vpgl/algo/tests/test_affine_rectification.cxx: In function 'void test_affine_rect()': .../core/vpgl/algo/tests/test_affine_rectification.cxx:40:3: error: 'abs' was not declared in this scope Please commit the patch below to fix it. When committing to vxl it is your responsibility to monitor the dashboard: http://open.cdash.org/index.php?project=vxl and fix problems in a timely manner. Thanks, -Brad diff --git a/core/vpgl/algo/tests/test_affine_rectification.cxx b/core/vpgl/algo/tests/test_affine_rectification.cxx index 53a5a35..4ffba5d 100644 --- a/core/vpgl/algo/tests/test_affine_rectification.cxx +++ b/core/vpgl/algo/tests/test_affine_rectification.cxx @@ -37,7 +37,7 @@ static void test_affine_rect() vnl_matrix_fixed<double, 1, 1> val = P2.transpose()*FAM*P1; vcl_cout << val[0][0] << vcl_endl; - TEST("check computed f", abs(val[0][0]) < 0.01, true); + TEST("check computed f", vcl_abs(val[0][0]) < 0.01, true); // test computation of rectification matrices vcl_vector<vnl_vector_fixed<double, 3> > img_p1, img_p2; |
From: Ozge C. O. <oz...@vi...> - 2013-12-05 17:25:49
|
ok, fixed and committed. thanks. On Thu, Dec 5, 2013 at 9:12 AM, Brad King <bra...@ki...> wrote: > Ozge, > > The vxl nightly dashboard builds have failed since you added this test: > > http://open.cdash.org/viewBuildError.php?buildid=3126535 > .../core/vpgl/algo/tests/test_affine_rectification.cxx: In function 'void > test_affine_rect()': > .../core/vpgl/algo/tests/test_affine_rectification.cxx:40:3: error: 'abs' > was not declared in this scope > > Please commit the patch below to fix it. > > When committing to vxl it is your responsibility to monitor the dashboard: > > http://open.cdash.org/index.php?project=vxl > > and fix problems in a timely manner. > > Thanks, > -Brad > > diff --git a/core/vpgl/algo/tests/test_affine_rectification.cxx > b/core/vpgl/algo/tests/test_affine_rectification.cxx > index 53a5a35..4ffba5d 100644 > --- a/core/vpgl/algo/tests/test_affine_rectification.cxx > +++ b/core/vpgl/algo/tests/test_affine_rectification.cxx > @@ -37,7 +37,7 @@ static void test_affine_rect() > > vnl_matrix_fixed<double, 1, 1> val = P2.transpose()*FAM*P1; > vcl_cout << val[0][0] << vcl_endl; > - TEST("check computed f", abs(val[0][0]) < 0.01, true); > + TEST("check computed f", vcl_abs(val[0][0]) < 0.01, true); > > // test computation of rectification matrices > vcl_vector<vnl_vector_fixed<double, 3> > img_p1, img_p2; > -- Dr. Ozge C. Ozcanli Computer Vision Scientist, Vision Systems Inc. Providence, RI phone: (401)427-0860 email: oz...@vi... |
From: Brad K. <bra...@ki...> - 2013-12-05 16:36:27
|
On 12/05/2013 11:25 AM, Ozge Can Ozcanli wrote: > ok, fixed and committed. thanks. Great, thanks. -Brad |