Great, thanks, I'll come up with a test for it! I looked it up, and you were right, not all compilers will recognize the "and" and "or" keywords, so I'll change that to the ASCII symbols. Does anyone else have any comments?

Andrew

On Mon, Apr 25, 2011 at 4:35 PM, Peter Vanroose <peter_vanroose@yahoo.co.uk> wrote:
Andrew,

I just quickly scanned through your source file, and it certainly looks OK to me in terms of (1) passes compilation, (2) is sufficiently documented, and (3) follows the vxl standards.
Maybe just add a (small) test which calls the compute() method and verifies the result.
Such a test should go in a new (separate) file in gel/mrc/vpgl/algo/tests/

(One minor remark: I would replace "or" by "||"; could be that some compilers would not understand the "or", I'm not sure.)

-- Peter.














--

--- Den mån 2011-04-25 skrev Andrew Hoelscher <aoh4@cornell.edu>:

Från: Andrew Hoelscher <aoh4@cornell.edu>
Ämne: Re: [Vxl-maintainers] Vpgl
Till: "Joe Mundy" <mundy@lems.brown.edu>
Kopia: vxl-maintainers@lists.sourceforge.net
Datum: måndag 25 april 2011 21:47


Joe,

Sounds good, attached is the file I would like to add.

-Andrew

On Mon, Apr 25, 2011 at 12:57 PM, Joe Mundy <mundy@lems.brown.edu> wrote:
Andrew,

Probably the easiest approach is for you to become a VXL developer. Why
don't you send and example of your code. If it looks reasonable to us,
then you just have to ask one of the administrators to add you to the list
of developers and you can update the repository directly going forward.

Joe Mundy


-----Infogad bilaga följer-----

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today.  Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd

-----Infogad bilaga följer-----

_______________________________________________
Vxl-maintainers mailing list
Vxl-maintainers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/vxl-maintainers