Re: [VuFind-Tech] Hide values of facet

[Demian K. <dem...@vi...>]

Thanks for catching this, Jochen. I'm not sure how this ever worked, or how it got pushed into master without any test. In any case, I believe that this commit fixes the bugs and adds test coverage:

https://github.com/vufind-org/vufind/commit/dc44c3e3b78396739d8a92b7330559db02228686

- Demian
________________________________________
From: Jochen Lienhard [lie...@ub...]
Sent: Friday, February 05, 2016 4:05 AM
To: vufind-tech Tech
Subject: [VuFind-Tech] Hide values of facet

Hi,

I tried to use the 'hide values of facet' in the current release and the
master, but it seems not to work.

I found two 'bugs'.

1) line 122 in
module/VuFind/src/VuFind/Search/Solr/HideFacetValueListener.php
array_keys($facets[$facet]) is NULL, so it must be
array_keys($facets[$facet]->toArray()),
because $facets[$facet] is a NamedList object.

2) the remove function in
module/VuFindSearch/src/VuFindSearch/Backend/Solr/Response/Json/NamedList.php
seems not to work, because the key($this->list) is NULL.

Have somebody the same problem?
@Frank will you fix it?
Is there a test case for the hide option?

Greetings

Jochen

--
Dr. rer. nat. Jochen Lienhard
IT Dezernat

Albert-Ludwigs-Universität Freiburg
Universitätsbibliothek
Platz der Universität 2 | Postfach 1629
79098 Freiburg          | 79016 Freiburg

Telefon: +49 761 203-3908
E-Mail: lie...@ub...
Internet: www.ub.uni-freiburg.de


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Vufind-tech mailing list
Vuf...@li...
https://lists.sourceforge.net/lists/listinfo/vufind-tech