From: Andrew N. <as...@gm...> - 2009-09-15 19:45:33
|
Moving this conversation to vufind-tech. Maybe I forgot to check in the mysql.sql file change. It should be VuFind and not local - if you want to go ahead and make the change - go for it! Andrew On Tue, Sep 15, 2009 at 3:10 PM, Demian Katz <dem...@vi...>wrote: > Glad to help -- I'll work on the JIRA entries tomorrow. > > > > Regarding the database structure issue, I'm working with the latest > mysql.sql file from the trunk. The source field of the resource table > defined there still appears to be defaulting to "local". If that is not > correct, perhaps one of your local changes got lost somewhere. If "local" > is the correct value, then the problem is a bug in the templates. I'm happy > to fix this one way or the other if you let me know which value ("local" vs. > "VuFind") is actually correct. > > > > - Demian > > > > *From:* Andrew Nagy [mailto:as...@gm...] > *Sent:* Monday, September 14, 2009 4:30 PM > *To:* Demian Katz > *Cc:* vuf...@li... > *Subject:* Re: [VuFind-General] "Lists" Now in Code Repository > > > > Demian - thanks for the QA work! Please do add them to JIRA. > In regards to item #4. I made an update to the mysql.sql file. You will > need to regen your database structure for this to work. Unless you did this > and it is still broken. > > Thanks > Andrew > > On Mon, Sep 14, 2009 at 2:05 PM, Demian Katz <dem...@vi...> > wrote: > > I finally took a look at this. I found and fixed a couple of problems: > > > > 1.) XSS vulnerabilities in list names. > > 2.) List titles missing from AJAX "GetSaveStatuses" calls (and some > potential encoding problems related to this function). > > > > I also noticed, but did not have time to fix, some further issues: > > > > 1.) When an item is in multiple lists, GetSaveStatuses fails -- the JSON > return value is not set up to handle arrays properly. > > 2.) Putting the same item on multiple lists doesn't always work correctly > -- you sometimes get into a state where adding it to a second list > overwrites the tags that were used on the first list, and removing it from > one list removes it from all lists. However, this doesn't always happen -- > I'll have to do more thorough testing to determine how to reproduce the > issue consistently. > > 3.) The edit mode in MyResearch/Edit is broken -- hitting save causes a > fatal error. > > 4.) The source field in the resource MySQL table defaults to "local". > However, the code is looking for a value of "VuFind" to generate links > correctly. As a result, clicking on titles in the "Your Favorites" section > of the favorites page in MyResearch leads to incorrect URLs. > > 5.) I can't seem to create a public list -- every list I create has a > public value of 0 in the database regardless of the radio button I click on > the create form. I've tried tracing the value through the code, and it > seems to be passing correctly all the way down to the creation of the > User_list object, so I'm not sure why it's failing. > > > > Should I add all of these to JIRA? Has anybody else had a chance to play > with this? > > > > thanks, > > Demian > > > > *From:* Andrew Nagy [mailto:as...@gm...] > *Sent:* Tuesday, September 08, 2009 9:36 AM > > > *To:* vuf...@li... > *Subject:* [VuFind-General] "Lists" Now in Code Repository > > > > For those of you who are staying on the "bleeding edge" of VuFind - we have > a new feature checked into the code base. We've updated the "add to > favorites" functionality to include "lists." This allows a user to add > their favorites to a list that can be either public or private. A public > list can be shared - a great resource for faculty who would like to create a > list of resources in the library for their class. > > > > As always, there is still more work to be done here - but it is now > available for testing. > > Thanks > Andrew > > > |