No - just that one.  The return statement is the culprit.

On Fri, Jun 26, 2009 at 2:07 PM, Lovins, Daniel <daniel.lovins@yale.edu> wrote:
Andrew,

What about the other cases ... do those also stop the routine?

Daniel


-----Original Message-----
From: Andrew Nagy [mailto:asnagy@gmail.com]
Sent: Friday, June 26, 2009 10:00 AM
To: Lovins, Daniel
Cc: David Lacy; Greg Pendlebury; vufind-tech@lists.sourceforge.net
Subject: Re: [VuFind-Tech] Question on getFormat function in VuFindIndexer.java

Daniel - yes that looks like a bug.  When it hits the 245h "electronic resource" it stops the routine.  Does this 245h rule seem like a generic enough rule - or is too "local rule" sounding?  Should their be more 245h detection rules?  Either way - it should not stop the routine upon detection.

Andrew


On Fri, Jun 26, 2009 at 9:53 AM, Lovins, Daniel <daniel.lovins@yale.edu> wrote:


       This reminds me of another question I had. Forgive my ignorance of Java code, but are the cases in the getFormat function mutually exclusive? That is to say, if a record meets the criterion for the first case, i.e., MARC 245 subfield $h "Electronic resource", will all of the other cases be skipped, or will a test be made of every case for every record, so that each record might  be represented by multiple formats in the Solr index?


       Thanks.

       Daniel


       -----Original Message-----
       From: Andrew Nagy [mailto:asnagy@gmail.com]

       Sent: Friday, June 26, 2009 9:17 AM
       To: David Lacy
       Cc: Greg Pendlebury; Lovins, Daniel; vufind-tech@lists.sourceforge.net
       Subject: Re: [VuFind-Tech] Question on getFormat function in VuFindIndexer.java

       David - I believe you mean the output of the getFormat function is configurable - which has always been the case.  The part that is not configurable is the algorithm that does the detection of the format.

       I think we need to investigate creating a configuration file for the getFormat method to allow the detection to be configurable.

       Andrew


       On Fri, Jun 26, 2009 at 8:16 AM, David Lacy <david.lacy@villanova.edu> wrote:


              The getFormat function is now configurable in the new version of solrmarc. The function now returns formats that can be re-labled to your liking. We did though alter the function to better reflect the multi-formated nature of a lot of our records. For instance we no longer use eBook as a format. It would either come through as Book and Online, or Book and DataDisc.



              I would be happy to share as well.



              David Lacy

              Falvey Library Technology Services

              Villanova University

              library.villanova.edu

              610-519-7361



              From: Greg Pendlebury [mailto:Greg.Pendlebury@usq.edu.au]
              Sent: Thursday, June 25, 2009 8:30 PM
              To: 'Andrew Nagy'; 'Lovins, Daniel'

              Cc: 'vufind-tech@lists.sourceforge.net'; 'solrmarc-tech@googlegroups.com'
              Subject: Re: [VuFind-Tech] Question on getFormat function in VuFindIndexer.java



              I rewrote that area extensively for our Library and I'm happy to share, but the thing I get most when looking at stuff like this is that every Library will have differences (sometimes subtle, sometimes glaring).



              We ended up using 'format' and 'sub_format' to bring an even greater degree of distinction:



              Greg Pendlebury
              Electronic Services Officer (Systems Team)
              Division of Academic Information Services
              University of Southern Queensland
              Phone: +61 7 4631 1501
              Fax: +61 7 4631 1841





       ________________________________

              From: Andrew Nagy [mailto:asnagy@gmail.com]
              Sent: Friday, 26 June 2009 8:54 AM
              To: Lovins, Daniel
              Cc: vufind-tech@lists.sourceforge.net; solrmarc-tech@googlegroups.com
              Subject: Re: [VuFind-Tech] Question on getFormat function in VuFindIndexer.java

              Daniel - This is definitly a VuFind issue.  I made that comment :)  This was something that I came across when developing the algoritm to detect the format from a marc record.  I found that if I captured the C from the 007 it was making too many records "Electronic".  Speaking of - I don't even like the term Electronic as a format - but I couldn't come up with a better term.  It's probably time that we re-evalute the format detection algortihm and revise it.  Please feel free to make any suggestions.

              Andrew

              On Thu, Jun 25, 2009 at 5:10 PM, Lovins, Daniel <daniel.lovins@yale.edu> wrote:

              Not sure if this is a VuFind question or a SolrMarc question ...

              I've been looking at how electronic resources are indexed in Solr.

              In VuFindIndexer.java (e.g., http://tinyurl.com/nevew8), where it's looking at records that have the value 'C' (= "Electronic Resource") in MARC 007 byte 0, and an R (= "remote") in byte 01, there's an in-line comment on lines 130-131: "Do not return - this will cause anything with an 856 field to be labeled as "Electronic".

              I'm just not sure what this means.

              The default for this routine (Case C) is "Software". Wouldn't the default kick in if nothing is returned? And how does the 856 relate to this?

              Thanks for your help.

              Daniel



              Daniel Lovins
              Metadata and Emerging Technologies Librarian
              Catalog & Metadata Services
              Sterling Memorial Library
              Yale University
              PO Box 208240
              New Haven, CT 06520
              daniel.lovins@yale.edu
              tel: 203/432-1707
              fax: 203/432-7231
              ------------------------------------------------------------------------------
              _______________________________________________
              Vufind-tech mailing list
              Vufind-tech@lists.sourceforge.net
              https://lists.sourceforge.net/lists/listinfo/vufind-tech



       ________________________________

              This email (including any attached files) is confidential and is for the intended recipient(s) only. If you received this email by mistake, please, as a courtesy, tell the sender, then delete this email.

              The views and opinions are the originator's and do not necessarily reflect those of the University of Southern Queensland. Although all reasonable precautions were taken to ensure that this email contained no viruses at the time it was sent we accept no liability for any losses arising from its receipt.

              The University of Southern Queensland is a registered provider of education with the Australian Government (CRICOS Institution Code No's. QLD 00244B / NSW 02225M)