#85 Having only one observation causes range error

Defect
closed-fixed
Adam
Charts (44)
5
2009-12-20
2009-12-04
Adam
No

In my travels to try and fix an issue with the comment codes, I ran into this. I constructed a file with one valid observation in it and when I loaded it got a range error. Turns out in setting the magscale the max can be smaller than the min. This then causes an exception to be thrown. You can test this with the attached file on revision 312.

Discussion

  • Adam
    Adam
    2009-12-04

    file with one entry for replication.

     
    Attachments
  • Adam
    Adam
    2009-12-04

    patch to correct this issue.

     
    Attachments
  • Adam
    Adam
    2009-12-04

    • assigned_to: david_benn --> adamweber
    • status: open --> open-accepted
     
  • David Benn
    David Benn
    2009-12-04

    Nice catch.

     
  • mikeu
    mikeu
    2009-12-04

    See also my comments at 2907603 which is now closed as a duplicate.

     
  • Adam
    Adam
    2009-12-17

    Ahh sorry bout that, admittedly I didn't do a search for this problem.

    However, I hope that I've made up for it by putting a fix for it in R345.

    Let me know if you see any issues or you feel we can close this issue as well.

    Thanks,

     
  • mikeu
    mikeu
    2009-12-19

    No worries, Adam.

    Here's an interesting bit. Try retrieving IL Aqr from the database with a range of JD 2455167.9218 to 2455167.9219 and see a blank chart. Then choose Change Series to reveal the I band datapoint.

    Then try getting JD 2455167.916 to 2455167.917 which is what I was initially trying to do: test the retrieval of a single data point. Your fix works well, for both the V and (when Series selected) the I point.

    Though I did stumble upon an edge case that we should consider how to handle. Should VStar display a message that there are no Vis or V obs? I would consider that a question for another tentry. This one looks fixed to me.

     
  • mikeu
    mikeu
    2009-12-19

    • status: open-accepted --> open-fixed
     
  • David Benn
    David Benn
    2009-12-19

    Re: Mike's last comment, another tentry sounds like a good idea.

     
  • mikeu
    mikeu
    2009-12-20

    Created 2917869 for the blank chart issue described below. Closing this one.

     
  • mikeu
    mikeu
    2009-12-20

    • status: open-fixed --> closed-fixed