#159 uncertaintyhq vs uncertainty

Defect
closed-fixed
David Benn
5
2010-05-26
2010-03-24
Sara Beck
No

Currently, VStar will use the value of the uncertainty field whenever uncertaintyhq is null. The same should be true if uncertaintyhq is zero or blank or in some other way unusable and uncertainty has a useful value in it. If the value of uncertainty is also un-useable, then 0.0 should be used.

Discussion

  • David Benn
    David Benn
    2010-03-25

    • status: open --> open-fixed
     
  • David Benn
    David Benn
    2010-03-25

    • labels: 1195832 --> Data Sources
    • milestone: 952198 --> Defect
     
  • David Benn
    David Benn
    2010-03-26

    While testing the fix below, Sara asked the question: why don't I see any uncertainty values, e.g. for eps aur, loaded from database (e.g. last 2 years). The answer turns out to be that the SQL query has always been wrong and we have never shown uncertainty values in database loaded obs. No-one noticed!

    We should put together a manual GUI level manual regression test, in addition to random testing.

    Fixed in http://vstar.svn.sourceforge.net/viewvc/vstar?view=rev&revision=452

     
  • David Benn
    David Benn
    2010-03-26

    I forgot to add: please check. :)

     
  • Sara Beck
    Sara Beck
    2010-03-29

    The error bars on the plot now look great, David.

    I am now wondering about the "List Observations" table and what should be displayed where. I noticed that the value of the "uncertainty" field is given after the magnitude as +/- uncertainty, while "HQ uncertainty" is given its own column in the table. For example, in the case of the star "3C 273" for JD 2454212.724233, the I-band data (band = 5), observer = JM uncertainty = 0.03 and uncertaintyhq = 0.01. The error bars are +/- 0.01 mags long as they should be, but in the magnitude field of the table, it reads 11.95 (+/- 0.03) and the HQ uncertainty reads 0.01. Would it be less confusing just to eliminate the "HQ uncertainty" column in the table and put "plotted uncertainty" with the magnitude?

     
  • Sara Beck
    Sara Beck
    2010-05-26

    • status: open-fixed --> closed-fixed