#13 Revision number in About help not updating

Defect
closed-works-for-me
mikeu
2
2009-09-21
2009-07-27
mikeu
No

With commit 129 the revision number displayed in the Help -> About popup did not update. As of rev 131 it still displays 128.

Discussion

  • mikeu
    mikeu
    2009-07-27

    • priority: 5 --> 7
     
  • mikeu
    mikeu
    2009-07-27

    • assigned_to: mu301 --> nobody
     
  • David Benn
    David Benn
    2009-07-29

    • assigned_to: nobody --> david_benn
     
  • David Benn
    David Benn
    2009-07-29

    I'm manually updating this at the moment while I sort out the best way to handle it. The file in which the rev is stored by svn must have itself changed in order for the revision to be modified on commit.

     
  • Adam
    Adam
    2009-09-10

    I know there is a command called svnversion that could be used during ant runs and put into some source with ant tag replacements maybe?

     
  • David Benn
    David Benn
    2009-09-10

    • priority: 7 --> 6
     
  • Adam
    Adam
    2009-09-10

    http://svnbook.red-bean.com/en/1.0/svn-book.html#svn-ch-1-sect-6 lists it, so I'm assuming it's going to be in all svn installations. The only weird part about it is it lists when the local copy is modified so that might be a little undesirable. I built a patch and an added template file with a class that would return the revision, I'm going to try and attach to this.

     
  • Adam
    Adam
    2009-09-10

    patch -p0 < patch from trunk should do it.

     
    Attachments
  • Adam
    Adam
    2009-09-10

    template that build.xml not expects to keep the revision up to date.

     
  • David Benn
    David Benn
    2009-09-11

    • assigned_to: david_benn --> adamweber
     
  • David Benn
    David Benn
    2009-09-11

    • milestone: --> Defect
     
  • David Benn
    David Benn
    2009-09-19

    Applied a slightly modified form of this patch in r202: http://vstar.svn.sourceforge.net/viewvc/vstar?view=rev&revision=202

    The only drawback of this approach so far as I can tell is that the revision number will always be one behind, since the rev num tag is updated in RevisionAccessor.java to be included in *before* addition to dist/vstar.jar and commit. However, at least the rev num should update from commit to commit.

    Mike, can you have a look at this and let us know whether you are happy with the solution?

     
  • David Benn
    David Benn
    2009-09-19

    • assigned_to: adamweber --> mu301
     
  • mikeu
    mikeu
    2009-09-21

    I'm seeing (svn revision 202M) for the vstar.jar that I built locally and (svn revision 201) for the prebuilt in dist that I pulled from svn. This works for me, since it distinguishes between a local build and the dist , while also uniquely identifying which version is being run.

     
  • mikeu
    mikeu
    2009-09-21

    • priority: 6 --> 2
    • status: open --> pending-works-for-me
     
  • David Benn
    David Benn
    2009-09-21

    I concur that the key criteria is uniqueness. Thanks Mike!

     
  • David Benn
    David Benn
    2009-09-21

    • status: pending-works-for-me --> closed-works-for-me