#114 Zero appearing as comment code and mishandled

Defect
closed-fixed
David Benn
8
2010-03-03
2010-01-17
David Benn
No

An assertion failure in CommentType led to the discovery that some observations (e.g. try recent eps aur and chi cyg obs from database) contain a '0' (zero) comment code. The submitter may have meant '0' (capital 'o'). This should be looked into. For now, we treat the errant comment code as '0', i.e. "OTHER". What is the most appropriate thin to do? We probably should not use an assertion here.

Discussion

  • David Benn
    David Benn
    2010-01-24

    We probably need to have a catch-all that maps anything that cannot be identified to a known comment code, e.g. OTHER.

     
  • David Benn
    David Benn
    2010-02-01

    • status: open --> open-fixed
     
  • Sara Beck
    Sara Beck
    2010-03-03

    I just tried Gamma Cas which has zeros in the comment code field on JD 2455143.27 and 2455156.335 and it now works fine.

     
  • Sara Beck
    Sara Beck
    2010-03-03

    • status: open-fixed --> closed-fixed