Re: [Vim-latex-devel] forward search pdf with okular patch

[Ted P. <te...@te...>]

Peter --

> thanks for the changes and yes git-send-mail is better but I have't
> set up the config for that. Will do next time.

	Great. The nice thing about having the git formatted patches is that
someone can check them in directly so you get credit right in the
changelog as the author of the commit.

> I see that you changed all linux viewers to have the unique option. I
> don't know if they have the option. I just know about okular.

	As you noted in a response, the unique option was already there for
those viewers.

> And yes, if I forward search in okular without the unique option,
> every time it opens another instance, which is quite annoying.
> I also use Skim on my Mac and it handles the instances by itself.

	Ah ha. That's very interesting. Okay then. Well, I've added --unique
and noted you in the commit message.

> You also changed the hardcoded dvi on xdvik, kdvi and xdvik. I don't
> know if they can handle pdfs. Okular can, as I use it with pdfs.
> I also see the unique option on kdvi. Why cant okular have it?

	I assumed that there was a reason why kdvi needed --unique. I wasn't
sure if okular needed --unique for effective forward searching or if
that was your personal preference. From your description above, I've
added --unique.

	Regarding the extensions, it was mainly to have a consistent style in
the section. After all, there is nothing that prevents that section from
being executed when the target is PDF...

...on the other hand, if the target is PDF and you're using the
DVI->PS->PDF build cycle (either via Vim-LaTeX build dependencies or via
your own custom compile line), then you might still want to use kdvi
even though you are building a PDF.

	Okay, you've convinced me. Reverting the s:targets on the dvi viewers. :)

	See recent pushes.

	Thanks --
	Ted


> Thanks,
> Peter
> 
> 
> On Fri, Jan 27, 2012 at 4:34 AM, Ted Pavlic <te...@te...> wrote:
>> Peter --
>>
>>        Good work. A few comments though. Before that, have you used patchbomb?
>> Sometimes it's nice to be able to scrutinize a patch within an e-mail
>> (as opposed to an attached file).
>>
>>> I use pdf as output and latex-suite only supports dvi on linux. I
>>> changed the hardcoded ".dvi" into ".s:target:". and it works now with
>>
>>        That's a good point. Back in the old days, source specials were an
>> exclusive DVI thing. That must be the reason for the hard-coded DVI. So
>> that's a good fix.
>>
>>> pdf files. Also added --unique option.
>>
>>        Some people might not like that. Why not just assume "--unique" will be
>> part of the viewer? Or is forward searching with okular hobbled without
>> unique instances?
>>
>>        Best --
>>        Ted
>>
>> --
>> Ted Pavlic <te...@te...>
> 
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Vim-latex-devel mailing list
> Vim...@li...
> https://lists.sourceforge.net/lists/listinfo/vim-latex-devel

-- 
Ted Pavlic <te...@te...>