Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#6 escapeshellarg for windows compliance

open
nobody
None
5
2011-08-04
2011-08-04
Anonymous
No

The ^ used in git is not windows compliant, unfortunately. To rectify this in function.php the following functions should escape their paramaters:

git_diff > return join("\n", run_git($project, "diff ".escapeshellarg("$from..$to")));
git_diffstat > return join("\n", run_git($project, "diff --stat ".escapeshellarg("$commit_base..$commit")));
git_get_rev_list > $cmd = "rev-list --max-count=$max_count ".escapeshellarg("$start");
git_ls_tree > $output = run_git($project, "ls-tree ".escapeshellarg("$tree"));

I'm not familiar with doing development on a shared open source project, otherwise I would just do it :).

Tim

Discussion