#5 Bad hash validation algo

closed-invalid
nobody
None
5
2010-08-06
2010-08-06
Bartosz Wiklak
No

Hi, function validate_hash in function.php does not validate names that include '_' (f.e. "MY_BRANCH" ). This make it impossible to view such branches.

Discussion

    • status: open --> open-invalid
     
  • This should've been already fixed in the following commit. Try with the latest git version and reopen this bug if needed.

    commit d98ea5141e0409d5ac0bf019fba54ddf1eab0c59
    Author: David Mudrak <david.mudrak@gmail.com>
    Date: Thu Jan 14 16:55:39 2010 +0100

    Underscore and capital letters are valid in tag/branch names

    Signed-off-by: Heikki Hokkanen <hoxu@users.sf.net>

     
    • status: open-invalid --> closed-invalid
     
  • Marc Bennewitz
    Marc Bennewitz
    2010-09-14

    Branches with a slash are valid, too!
    -> we added the "\/" to your pattern on validate_hash function:
    -> see http://git.zendframework.com/

     
  • Slahes should have been fixed in:

    commit abf9aba87bdb41cb27a95fefcc2f1d9039a04963
    Author: Shawn Stratton <sstratton@howstuffworks.com>
    Date: Thu May 19 14:50:50 2011 -0400

    Added support for heads with / in the name