#83 Remote monitor command stream and stability bug

v2.4.x
closed-accepted
nobody
None
bugfix
2014-08-14
2013-08-05
Uffe Jakobsen
No

Hi,

This patch fixes problems with the remote monitor being unable to handle a stream of commands like this:

# echo -e -n "r\nr\nr\nx\n" | nc localhost 6510

Also improved error checking is introduced - this improves handling of transmission errors for the remote monitor.

/Uffe

1 Attachments

Discussion

  • Uffe Jakobsen
    Uffe Jakobsen
    2013-08-09

    FYI: Now that patch #81 (https://sourceforge.net/p/vice-emu/patches/81/) is applied - this patch may not apply clean since this patch also contains the small changes from patch #81

    -    last_cmd = cmd;
    +    if (exit_mon) {
    +        last_cmd = NULL;
    +    } else {
    +        last_cmd = cmd;
    +    }
    
     
  • gpz
    gpz
    2013-08-11

    • status: open --> pending-accepted
     
  • gpz
    gpz
    2013-08-11

    applied in r27718, thanks for the patch!

    as a sidenote: please do not use cpp style comments in your patches, makes applying them less of a hazzle :)

     
    • Uffe Jakobsen
      Uffe Jakobsen
      2013-08-12

      Will do - it is a habit from $work :-)

       
    • status: pending-accepted --> closed-accepted