#31 nominmax cleanup

open
nobody
None
5
2012-11-10
2011-11-27
logzero
No

Disable windows min/max macros by adding NOMINMAX to the preprocessor defines. Patch is against vega-vc9.

Related to https://sourceforge.net/tracker/?func=detail&aid=3353679&group_id=19507&atid=319507

Discussion

  • logzero
    logzero
    2011-11-27

    vega-vc9 nominmax

     
    Attachments
  • Klauss++
    Klauss++
    2011-11-27

    Looks good here, but I have no windows setup so I can't confirm.

    Can someone else please confirm and apply?

     
  • logzero
    logzero
    2012-11-10

    vegastrike source nominmax

     
    Attachments
  • logzero
    logzero
    2012-11-10

    • summary: std::min/max for vega-vc9 --> nominmax cleanup
     
  • logzero
    logzero
    2012-11-10

    I've uploaded the accompanying vegastrike nominmax patch, which removes nominmax defines from source.

    Both patches are rather trivial, please review/apply.

     
  • Klauss++
    Klauss++
    2012-11-10

    Why would you remove them from source? It will only make life harder on those trying to build a new solution from scratch.

     
  • logzero
    logzero
    2012-11-10

    Well, if you prefer to put NOMINMAX checks all over the place to deal with this msvc specific issue...

    From my point of view it makes more sense to define it globally once.

     
  • Klauss++
    Klauss++
    2012-11-11

    It does make more sense. But that can be done in code: ie: in vs_globals.h
    or some other header that's always included before anything else. And it
    can still be done in the solution file just in case.

     
  • logzero
    logzero
    2012-11-12

    OK. I think you can close/reject this one then.

     
  • Klauss++
    Klauss++
    2012-11-13

    Why?

    It would be nice if you could come up with a patch to vs_globals or some other global vs header that can let us stop using mymin/mymax.