#133 little typos in r1192

open
nobody
5
2013-04-06
2013-04-06
galtgendo
No

Perhaps I'm bit impatient, but:
- trunk/src/gba/remote.cpp@1188: seems to be correct only for Windows, fails to build on linux
- trunk/src/gba/GBA-arm.cpp@1192: just a guess (as it's assembler), but it seems
'EMIT2(add, KONST(4), ax)' should be 'EMIT2(add, KONST(4), eax)'

Oh, and to re-address patch 3477801: looks like that github fork got nowhere; not that's surprising - gtk+ upstream has been strongly suggesting clutter *instead*. I no longer recall how I triggered that crash upon exit and can no longer reproduce it.

Discussion

  • 1193 should fix remote.cpp, im not touching the arm file though.

     
  • galtgendo
    galtgendo
    2013-04-08

    ...so, going by the recent commit, my guess about assembler was correct.

    Also, re. r1193 (commit log message) - going by the manpage, the code is more or less already correct on Linux (chances are Windows' INVALID_SOCKET is equivalent to '-1', which is the value that should be returned upon error).