From: Julian S. <js...@ac...> - 2006-01-29 20:54:52
|
On Thursday 26 January 2006 02:52, Nicholas Nethercote wrote: > On Wed, 25 Jan 2006, Julian Seward wrote: > >> One problem is that Valgrind's client requests currently have a maximum > >> of four arguments. > > > > Pretty harmless. All the args are passed in a block in memory to > > avoid getting tangled in an args-in-registers style swamp, so > > that block can easily be expanded by one word to accommodate an > > extra argument. > > But then VALGRIND_MAGIC_SEQUENCE would have 8 args instead of 7, which > would screw up things for those existing uses of it in people's code, no? But VALGRIND_MAGIC_SEQUENCE is a low-level macro used as a building block for the higher client-request macros that users should be using. So I don't thing there should be a problem. In any case I sure hope not since I recently renamed it to VALGRIND_DO_CLIENT_REQUEST as that's a more sensible name for it. J |