From: Vitaliy I. <vit...@gm...> - 2011-07-07 16:36:15
|
>From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 From: Vitaliy Ivanov <vit...@gm...> Date: Thu, 7 Jul 2011 19:29:06 +0300 Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix We should cleanup memory even though 'putenv' fails. Signed-off-by: Vitaliy Ivanov <vit...@gm...> --- arch/um/os-Linux/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c index fb2a97a..67fe012 100644 --- a/arch/um/os-Linux/main.c +++ b/arch/um/os-Linux/main.c @@ -107,8 +107,8 @@ static void setup_env_path(void) snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path); if (putenv(new_path)) { perror("couldn't putenv to set a new PATH"); - free(new_path); } + free(new_path); } extern void scan_elf_aux( char **envp); -- 1.7.0.4 |
From: Richard W. <ri...@no...> - 2011-07-07 16:49:00
|
Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov: > >From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 > > From: Vitaliy Ivanov <vit...@gm...> > Date: Thu, 7 Jul 2011 19:29:06 +0300 > Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix > > We should cleanup memory even though 'putenv' fails. > > Signed-off-by: Vitaliy Ivanov <vit...@gm...> > --- > arch/um/os-Linux/main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c > index fb2a97a..67fe012 100644 > --- a/arch/um/os-Linux/main.c > +++ b/arch/um/os-Linux/main.c > @@ -107,8 +107,8 @@ static void setup_env_path(void) > snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path); > if (putenv(new_path)) { > perror("couldn't putenv to set a new PATH"); > - free(new_path); > } > + free(new_path); Uhhh, this will kill the PATH variable. putenv() does not copy the string... Thanks, //richard |
From: Vitaliy I. <vit...@gm...> - 2011-07-08 10:16:27
|
On Thu, Jul 7, 2011 at 7:48 PM, Richard Weinberger <ri...@no...> wrote: > Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov: >> >From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 >> >> From: Vitaliy Ivanov <vit...@gm...> >> Date: Thu, 7 Jul 2011 19:29:06 +0300 >> Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix >> >> We should cleanup memory even though 'putenv' fails. >> >> Signed-off-by: Vitaliy Ivanov <vit...@gm...> >> --- >> arch/um/os-Linux/main.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c >> index fb2a97a..67fe012 100644 >> --- a/arch/um/os-Linux/main.c >> +++ b/arch/um/os-Linux/main.c >> @@ -107,8 +107,8 @@ static void setup_env_path(void) >> snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path); >> if (putenv(new_path)) { >> perror("couldn't putenv to set a new PATH"); >> - free(new_path); >> } >> + free(new_path); > > Uhhh, this will kill the PATH variable. > putenv() does not copy the string... That's actually depends on the version of glibc that you use. But yes, agree, my fault. Please drop this one. I hope I'm not in your shit-list already.:) BTW, you said that you will share your git tree on kernel.org, is there any news? I'm tracking what patches are accepted not to resend them again. Thanks, Vitaliy |
From: Richard W. <ri...@no...> - 2011-07-08 10:22:58
|
Am Freitag 08 Juli 2011, 12:16:20 schrieb Vitaliy Ivanov: > On Thu, Jul 7, 2011 at 7:48 PM, Richard Weinberger <ri...@no...> wrote: > > Am Donnerstag 07 Juli 2011, 18:37:48 schrieb Vitaliy Ivanov: > >> >From 6db3c87f57e3e61d968da79f01fb21ba17fd5bc0 Mon Sep 17 00:00:00 2001 > >> > >> From: Vitaliy Ivanov <vit...@gm...> > >> Date: Thu, 7 Jul 2011 19:29:06 +0300 > >> Subject: [PATCH 3/3] uml: os-Linux/main.c memory leak fix > >> > >> We should cleanup memory even though 'putenv' fails. > >> > >> Signed-off-by: Vitaliy Ivanov <vit...@gm...> > >> --- > >> arch/um/os-Linux/main.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c > >> index fb2a97a..67fe012 100644 > >> --- a/arch/um/os-Linux/main.c > >> +++ b/arch/um/os-Linux/main.c > >> @@ -107,8 +107,8 @@ static void setup_env_path(void) > >> snprintf(new_path, path_len, "PATH=%s" UML_LIB_PATH, old_path); > >> if (putenv(new_path)) { > >> perror("couldn't putenv to set a new PATH"); > >> - free(new_path); > >> } > >> + free(new_path); > > > > Uhhh, this will kill the PATH variable. > > putenv() does not copy the string... > > That's actually depends on the version of glibc that you use. But yes, > agree, my fault. Please drop this one. > I hope I'm not in your shit-list already.:) No problem. :) > BTW, you said that you will share your git tree on kernel.org, is > there any news? I'm tracking what patches are accepted not to resend > them again. Yeah, I'll announce it on use...@li.... It's done when it's done. :-P Thanks, //richard |
From: Vitaliy I. <vit...@gm...> - 2011-07-08 10:37:07
|
>> BTW, you said that you will share your git tree on kernel.org, is >> there any news? I'm tracking what patches are accepted not to resend >> them again. > > Yeah, I'll announce it on use...@li.... > It's done when it's done. :-P Sure. No problems. - Vitaliy |