From: Jeff Dike <jdike@ka...> - 2002-09-17 02:11:49
Here are some comments from a quick look through the patch.
ARCH_SYSCALLS is wrong. It should only contain entries for those system
calls which sparc has and some other arches don't. If there are entries
in sys_call_table.c which sparc doesn't have, then they should be moved into
the i386 (and ppc) ARCH_SYSCALLS. And it appears that there were, given
the number of system call entries commented out from sys_call_table.c.
There are a number of non-functional contributions to the patch, such as
whitespace differences and reformatting. It would be nice to get rid of them
so that the patch becomes more information-rich.
The __delay that I stuck in arch/um/kernel/time_kern.c which contains x86
asm should be moved under sys-i386 and sys-sparc.
You should remove link.ld from the diff.
The stubs in arch/um/sys-sparc64/ptrace.c and arch/um/sys-sparc64/sigcontext.c
should probably panic.
There should definitely be no modifications in include/asm-sparc64.
include/asm-um/checksum-sparc64.h looks like it should just include whatever
sparc header you copied into it.