Re: [uml-devel] [PATCH] Ethertap in 2.4.5 - routing incorrect.

[Jeff D. <jd...@ka...>]

wst...@po... said:
> The first line doesn't head out the right interface because I'm using
> the same IP for both my eth0 and tap1 devices.

I didn't think that was legal.  Anyway, a device route seems to make sense.

wst...@po... said:
>	How about replacing:
>  char *ifconfig_argv[] = { "ifconfig", dev, "arp", "mtu", "1500", gate_addr,
>                            "up", NULL };
>	with:
>  char *ifconfig_argv[] = { "ifconfig", dev, "arp", "mtu", "1500", gate_addr,
>                            "netmask", "255.255.255.255", "up", NULL };

Seems fine to me.

> By the way, in uml_net.c/ethertap(), I don't think ether_addr is
> actually being used.

I don't think so either :-)

>   char *ifconfig_argv[] = { "ifconfig", dev, "hw", "ether",
> ether_addr,
>                             "arp", "mtu", "1500", gate_addr,
>                             "netmask", "255.255.255.255", "up", NULL
> }; 

This one I'm not so sure about.  What does it mean for a tap device to have an 
ether address?  It means that the two ends can arp each other.  Is there any 
point to that?  It doesn't do any good, so we have to set routes out to the 
host anyway.

If the ether address isn't any good for anything, I'd just as soon get rid of 
it and clean up the code a bit.

				Jeff