From: Jeff D. <jd...@ka...> - 2001-06-15 18:15:45
|
OK, this is in my pool, and it'll be in the next cvs update. bu...@gn... said: > Issues(TM): > * Bluntly changing stat, open, lseek calls to calls to their 64bit > counterparts might break really old libc's that don't understand > __USE_LARGEFILE64 (The glibc 2.1 from Red Hat 6.1, which was the oldest > install I could find, does seem to understand it). The alternative is to use > -D_FILE_OFFSET_BITS=64, which transparently converts lots of fs calls to > their 64 bit counterparts, but subtly breaks modules. If this is a problem, we can always add a no-64-bit config which does a bunch of '#define foo64 foo'. >* 64bit-ising do_statfs is arguably silly. We now use statvfs64 for getting > info on the fs, but the in-kernel 'struct statfs' which we fill only has > 32bit fields anyway. I left that as is, but it might make sense to hide the 64-bitness in the user side and have it pass ints back out. Jeff |