Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade <bla...@ya...>]

On Thursday 07 April 2005 08:50, Rob Landley wrote:
> On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:
> > Anyway, from looking at what you quote, it's identical to the code in
> > arch/um/kernel/Makefile. Quoting the correct code:
> >
> > quiet_cmd_quote2 = QUOTE   $@
> > cmd_quote2 = sed -e '/CONFIG/{'          \
> >                   -e 's/"CONFIG"\;/""/'        \
> >                   -e 'r $(obj)/config.tmp'     \
> >                   -e 'a""\;'                   \
> >                   -e '}'                       \
> >                   $< > $@
> >
> > As you see, there is a fourth expression, *here*. But it's -e '}'.
> >
> > This patch went in after 2.6.11, I'm noticing - wow, are releases getting
> > so slow?
> >
> > > > System is Debian Woody,
> >
> > Can you post your sed version? and Rob, can you then test it and fix the
> > code? Please save the correct config.c currently created and check it for
> > reference.
>
> I enabled SKAS mode and the build finished.  The sed bit didn't break for
> me:
>
>   CHK     usr/initramfs_list
>   QUOTE   arch/um/kernel/config.tmp
>   QUOTE   arch/um/kernel/config.c
>   CC      arch/um/kernel/config.o
>
> And I'm using knoppix, which is based on debian.
But with updated packages (i.e. unstable/testing). If the patch is so little 
and without downsides, there's no point in not merging it.
> From the error message, it seems to be complaining about the "a" command. 
> If you're using a really really really old version of sed, it might insist
> on a gratuitous line break before the line to be added.  (I know it did
> back in the 1970's, but I didn't think anything remotely modern had that
> limitation.) So try splitting the command in half like this:
>
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                   -e 's/"CONFIG"\;/""/'        \
>                   -e 'r $(obj)/config.tmp'     \
>                   -e 'a \'                   \
>                   -e '""\;'                  \
>                   -e '}'                       \
>                   $< > $@
>
> I just tried that here and it behaved the same way as the other version,
> for me...
Ok, Rob, finish handling this issue this and email me the patch (with a 
suitable changelog) when it's ready.

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade