From: Jeff D. <jd...@ka...> - 2003-03-10 20:56:48
|
lm...@su... said: > Is the basic principle OK or did I screw it up somewhere? Looks reasonable. > + ubd_control <dev>=<fail,clean> - make ubd fail or work cleanly again Change the name. You added something which is completely generic as far as the actual driver is concerned. The other drivers can now plug their own fault generators into it, so ubd_control seems like the wrong name. Maybe "fault", unless you have bigger plans for this than fault injection. mconsole_ubd_control and ubd_control look like they can share code with whoever you copied the implementation from :-) Factoring that code out would be a plus. Jeff |