#15 crash on OSF1/Tru64

v3.6
closed-accepted
Bug fix (11)
5
2006-08-02
2006-07-26
Anonymous
No

OS:
OSF1 deh12 V5.1 2650 alpha

Problem:
top crashes after running a couple hours.

From dbx:

signal Segmentation fault at
[do_threads_calculations:890 +0xc,0x12000eb6c]
Source not available
(dbx) where
> 0 do_threads_calculations(thisproc = 0x140661318)
["machine/m_decosf1.c":890, 0x12000eb6c]
1 get_process_info(si = 0x11fffbdb8, sel =
0x11fffbcd0, compare_index = 0)
["machine/m_decosf1.c":482, 0x12000ded0]
2 main( = 0, argc = 1, argv = 0x11fffc018)
["top.c":708, 0x12000b000]

We tried to debug it, and came up with the following
patch:

# diff m_decosf1.c.orig m_decosf1.c
886c886,888
< (void) task_threads(thistask, &threadarr,
&threadarr_l);
---
> if (task_threads(thistask, &threadarr,
&threadarr_l) != KERN_SUCCESS)
> return;

The same check is present in m_macosx.c (also a Mach-
based kernel).

Please review and apply.

regards,

Derkjan de Haan
haanjdj@xs4all.nl

Onno v/d Linden

Discussion

  • Logged In: YES
    user_id=687210

    Thanks for the patch.

     
    • assigned_to: nobody --> wnl
    • status: open --> closed-accepted