Menu

#67 Make trace show all usernames, idented or not

u2.10.12
closed-rejected
Entrope
None
5
2005-03-31
2005-03-26
Reed Loden
No

(Originally from LordLuke - Sat, 23 Mar 2002 01:12:25
+0100)

Trace is currently not showing a username for unidented
clients. I
looked in the rfc but it doesn't seem to mention this.
On other networks
it is showing the username wether idented or not.

This patch makes ircu always show the username.

Tested against
u2.10.12.alpha.00. Test.undernet.org B27AeEFfIKMpSU

2002-03-23 Bert Faes <bert.faes@pandora.be>

* s_misc.c made /trace reply always show the
username

Discussion

  • Reed Loden

    Reed Loden - 2005-03-26

    Make trace show all usernames, idented or not

     
  • Reed Loden

    Reed Loden - 2005-03-26
    • assigned_to: nobody --> entrope
     
  • Nobody/Anonymous

    Logged In: NO

    There are a few places in ircu where no ident means no
    ident, not "show what the user pretended to have". O:lines
    are one (an O: can't match a "fake" ident). /trace is another.

     
  • Entrope

    Entrope - 2005-03-31
    • status: open --> closed-rejected
     
  • Entrope

    Entrope - 2005-03-31

    Logged In: YES
    user_id=10120

    The get_user_name() function is used in a number of places
    besides handling /trace. The string returned by it should
    not be changed in places where the missing ident means no
    ident (such as the O: line issue mentioned by the anonymous
    commenter).

     

Log in to post a comment.