#87 WHOWAS does not send required IP param for RPL_WHOISACTUALLY

u2.10.13
open
Entrope
Server (143)
5
2006-01-01
2005-12-31
Romain BIGNON
No

In m_whowas, there is this line :

send_reply(sptr, RPL_WHOISACTUALLY, temp->name, temp-
>username, temp->realhost);

But RPL_WHOISACTUALLY has this definition (s_err.c):

{ RPL_WHOISACTUALLY, "%s %s@%s %s :Actual user@host,
Actual IP", "338" },

So, there isn't ip in whowas.

Discussion

  • Reed Loden
    Reed Loden
    2006-01-01

    • milestone: 243691 --> u2.10.13
    • assigned_to: nobody --> entrope
     
  • Reed Loden
    Reed Loden
    2006-01-01

    Logged In: YES
    user_id=223621

    Fixed in revision 1.12.2.1 of ircd/m_whowas.c
    (u2_10_12_branch) by displaying "<untracked>" in the IP
    location of RPL_WHOISACTUALLY.

    As per Entrope, u2.10.13 probably should have the IP stored
    in struct User and have that refcounted, rather than having
    so much in whowas.

     
  • Reed Loden
    Reed Loden
    2006-01-01

    • summary: Bug in WHOWAS --> WHOWAS does not send required IP param for RPL_WHOISACTUALLY