Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#125 reserved identifier violation

open
nobody
None
5
2012-03-30
2012-03-30
Markus Elfring
No

I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source files. Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- _CORE_H_
http://umplayer.svn.sourceforge.net/viewvc/umplayer/umplayer/trunk/src/core.h?revision=181&view=markup

- _MPLAYERPROCESS_H_
http://umplayer.svn.sourceforge.net/viewvc/umplayer/umplayer/trunk/src/mplayerprocess.h?revision=176&view=markup

This usage does not fit to the expected naming conventions of the C/C++ language standard.
https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

Discussion